cleanup/nullable-ize Message/ classes #822
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gbirchmeier
added a commit
to gbirchmeier/quickfixn
that referenced
this pull request
Jan 24, 2024
gbirchmeier
force-pushed
the
message-cleanup
branch
from
7f140aa
to
4792ab4
Compare
gbirchmeier
force-pushed
the
message-cleanup
branch
from
4792ab4
to
2389b93
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It turns out I hate the Message class. Would love to merge FromString's logic into the constructor, but then I'd have to rewrite the MsgFactory logic and probably dive into a rabbit hole. Oh well. At least I can fix the nullable vars and take the DD instance var out.
Some breaking changes in here! See the changes to RELEASE_NOTES.md